Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repairing code coverage reporting and enabling SimpleCov HTML report generation #657

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

jrgriffiniii
Copy link
Contributor

This was discovered while @20LM22 was advancing #650.

@jrgriffiniii jrgriffiniii self-assigned this Jul 18, 2024
@jrgriffiniii
Copy link
Contributor Author

jrgriffiniii commented Jul 18, 2024

7451cee was the most concerning aspect of this PR to me. If removing these filters does not significantly lower the test coverage, then I would prefer to have these removed please. The test coverage was not adversely affected by removing these lines.

@jrgriffiniii
Copy link
Contributor Author

@jrgriffiniii jrgriffiniii changed the title Repairing SimpleCov HTML report generation Repairing code coverage reporting and enabling SimpleCov HTML report generation Jul 18, 2024
@20LM22 20LM22 merged commit 1c70890 into main Jul 18, 2024
4 checks passed
@20LM22 20LM22 deleted the i650-jrgriffiniii-simplecov-reporting branch July 18, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants