Error requesting Resource Sharing item

[rladdusaw]

Expected behavior

A request should be made

Actual behavior

The request causes an error

Impact of this bug

User is unable to request item

Honeybadger link and code snippet, if applicable

https://app.honeybadger.io/projects/54399/faults/103856161

NoMethodError: undefined method `[]' for nil:NilClass delivery_location.values.first[:contact_email] ^^^^^^^^^^^^^^^^</div>
70 | return I18n.t('requests.on_shelf.email') if library_code == "firestone"
-- | --
71 | delivery_location = Requests::BibdataService.delivery_locations.select { \|_key, value\| value[:library][:code] == library_code }
72 | delivery_location.values.first[:contact_email]
73 | end
74 | end

Implementation notes, if any

Assign this location: https://bibdata.princeton.edu/locations/delivery_locations/12

• Add delivery location for RES_SHARE$IN_RS_REQ bibdata#2304

[kevinreiss]

Looking at the stacktrace the user selected two volumes (E) and (A). A is already out on loan via Borrow Direct. The error came up because the code asked for a contact email from this location https://bibdata.princeton.edu/locations/holding_locations/RES_SHARE$IN_RS_REQ which has no delivery locations attached. I'm not 100 sure why the code is calling this a for an item that is a resource sharing request. Need to research if that is really necessary since the request system does not send staff notifications for ILLiad requests. However I think if we give this location a delivery location with an email we won't see these errors any longer.

[christinach]

resolved by pulibrary/bibdata#2305