Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iframe embed codes for figgy objects in figgy "share" button on viewer #6554

Open
1 of 3 tasks
kelea99 opened this issue Nov 21, 2024 · 0 comments
Open
1 of 3 tasks
Labels

Comments

@kelea99
Copy link
Contributor

kelea99 commented Nov 21, 2024

Summary

Right now : .. https://figgy.princeton.edu/uv.html#
versus what it should be "/viewer" . in the code itself.

Current state example

<iframe src="https://figgy.princeton.edu/uv.html#?manifest=https://figgy.princeton.edu/concern/scanned_resources/f1082b7d-3057-4543-9d2b-d71c67b2dea5/manifest&c=0&m=0&s=0&cv=0&config=/viewer/config/f1082b7d-3057-4543-9d2b-d71c67b2dea5.json&locales=en-GB:English (GB),cy-GB:Cymraeg,fr-FR:Français (FR),sv-SE:Svenska,xx-XX:English (GB) (xx-XX)&xywh=-2108,-246,7337,4910&r=0" width="560" height="420" allowfullscreen frameborder="0"></iframe>

Noticed by Ben Johnston from McGraw, who uses the embeds for his proejcts.

Impact

Please include hard deadlines, if the exhibit is part of an event, the issue is stopping work, etc.

Priority recommendation

  • asap
  • within the next 3 weeks
  • PO will prioritize

Sudden Priority Justification

Required if "asap" or "within the next 3 weeks" is checked. Add "Sudden Priority" and "Maintenance/Research" labels

Expected behaviour

Actual behaviour

Steps to reproduce behaviour

Screenshots

@kelea99 kelea99 added the bug label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant