Fix form builder and default forms #870
Conversation
| @@ -35,8 +35,7 @@ type GetPubFieldsInput = | |||
| * Get pub fields | |||
| * | |||
| * @param props - When nothing is supplied, return all the pub fields | |||
| * @param props.pubId - When supplied, return all the pub fields associated with the pub through pub values and the pub type of that pub | |||
| * When props.valuesOnly is true, only return the pub fields associated with the pub through pub values, not through the pub type | |||
There was a problem hiding this comment.
we stopped using the valuesOnly prop at some point, but the query was never updated. and now valuesOnly is actually the behavior we always want so i've updated the comments and removed the additional pub type fields join from the query.
i also checked and the only place we use this version of the query (passing the pubid) is on the pub editor that i'm fixing here.
| return rest; | ||
| const { slug, id, ...rest } = e; | ||
| // Rename id to avoid conflict with rhf generated id | ||
| return { ...rest, elementId: id }; |
There was a problem hiding this comment.
rather than restore the alias in the query, i rename id here, which is a little closer to where we actually use the elementId prop
kalilsn
changed the title
kalilsn
force-pushed
the
kalilsn/fix-element-deletion
branch
from
abe47ae to
e091773
Compare
|
Just for my understanding, does this now still let the pub/edit page render fields on the pub that are not on the default form? bc i think it should! otherwise how are you ever to change values whose fields are not on the default form? edit: tested it and yes it still does! |
Issue(s) Resolved
Resolves #868
High-level Explanation of PR
There are 3 different bugs causing unwanted fields to show up on the pubs page. This fixes two of them:
idtoelementId. This made it impossible to delete form elements because we use the presence ofelementIdto check whether the element has been saved already. If it hasn't been saved, it's immediately removed from the form. This change caused saved elements to have the same behavior, rather than marking them with{ deleted: true }and sending them to the backend to actually get removed.The third bug is just that we often create "empty" values and we don't have any way to delete them. So even after merging this and actually removing an element from the form, it may still show up on the pub update form until we make it possible to delete values. I would just filter these out in the query, except that there are a variety of empty values (
""," ",[{}]) not justnullso I don't really want to make a decision about how to handle that now. The create pub form should update correctly though!Test Plan
Same as the issue!
Screenshots (if applicable)
Notes