-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refinements to CSS/styling of Beta print templates #8380
Comments
Hey @jywarren after we get the tests merged and the changes are pushed live will tag Liz and other community members to test this out and hopefully figure out the shortcomings of the print option 😅 Will need some extensive testing with different types of content to understand where this might be failing |
Hey @jywarren can we get the work till now published if there are no bugs 😅 so that we can get this tested out with Liz and others ...with their feedback I can then make more changes to the template 🎉 |
This comment has been minimized.
This comment has been minimized.
Hey @ebarry I just looked at the pdfs they seem to be printed from the old print option 😅 and not the new This is how it looks on the new print option - can you check this print option once on the widescreen and let me know how it goes? Thanks ✌️ |
Also with the new printable(beta) option here I noticed the cards part is breaking on page change so I will try to fix it so that it stays in the entire card stays in a single page 😅 |
Thank you! I think the issue is that your great work has not yet been integrated all the way onto publiclab.org yet, so my comment was a bit hasty <3 |
Hi all! For reference, here is a snap of the current PDF styling (top of first page) on the left, vs. the previous one which is a little broken but has fonts that are a little closer to the online version of the page: I think the current one is looking great! Perhaps a little more vertical line spacing, and the use of Junction Light, could be nice? Also, a Q for @ebarry and other staff, do you want things like the # of revisions, last edited, shown at the top? Finally, what about removing the black lines around the images... i'm not set on it but it might look a little more spacious! Thanks @Tlazypanda !!! This is tremendous. If we are comfortable with this being better than the existing function, perhaps we should deprecate the old one already? |
+1 those ideas would be great @jywarren: change text to Junction Light, add more vertical line spacing, and removing the black outlines around images. As far as the information shown at the top, i tend to like to keep the evidence of "collaborative editing" even when using the content as simple printed handouts. I would vote to keep the "Last edited by" and "## revisions" but maybe lay them out more elegantly? Jeff, maybe you could advise here a bit? |
Hi, |
Just on thing more - copy & paste in a Word.docx works, but ... ;-) |
Hi, I'm really sorry @Tlazypanda to have missed your comment here. I think @ebarry is referring to some of the "Standard" typographic styles we use at Public Lab and I think it's a great idea. We don't have to do all the font sizes the same but you can see the standard usage of the Junction Light font in our print style guide here: https://publiclab.org/wiki/style-guide#Print+documents @steffnat aha, a really good point. Are the comments completely missing? I think we may need to add them to the print template, here: https://github.com/publiclab/plots2/blob/main/app/views/notes/print.html.erb That's also where our print-friendly stylesheets for this new print system are kept. We could move those to their own separate stylesheet file in something like Finally, it sounds like the clipping of text you're describing means we need to continue to tweak those stylesheets to get good consistent printing working. Are you at all interested in trying some of this out, @steffnat? Thanks all! |
Also just noting some fabulous features in https://evanbrooks.info/bindery/ which we should explore. Implementation looks really easy, too: const { makeBook, PageBreak, Footnote } = Bindery;
makeBook({
content: '#content',
rules: [
PageBreak({ selector: 'h2', position: 'before', continue: 'right' }),
Footnote({
selector: 'p > a',
render: (el, num) => `${num}: Link to ${el.getAttribute('href')}`;
}),
],
}); |
Hi @jywarren, |
Hi, thank you. I am not 100% sure where we are on the idea of including comments. Maybe @ebarry has input on this? I'll also ask some other @publiclab/community-reps. Maybe eventually we could include them optionally via a checkbox? |
Please describe the problem (or idea)
After the addition of the Printable (Beta) Version to the print options, it is now time to test it out and report bugs so that we can solve them and provide users with good experience with Printing.
Please show us where to look
Inviting the Public Lab team to test the Print view and report bugs found so we can correct them. Let this issue act as a main issue/thread for reporting bugs with print view.
The text was updated successfully, but these errors were encountered: