-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The coordinates lat & lon doesn't match the location on pin info window #1682
Comments
Hi @cesswairimu,@jywarren can you please look at it. |
Hi @illyShelly, really great catch π I was able to see the same on the website. I will look more into this, we would love your help too if your interested. thanks for opening this |
@cesswairimu Hi π I would love to! I tried to go through code base, but I am not familiar with it so I didn't know which file to test. |
This is the file https://github.com/publiclab/mapknitter/blob/main/app/views/front_ui/index.html.erb. I will add any info I find here too. thanks |
@cesswairimu hi, I just wonder. Last approx. 1 week I cannot see live on the website and when running locally the pins (location). Nor in Safari, nor in Chrome. I checked my settings, cookies and everything looks okay?? Not sure, why do I have this problem. btw. the location is wrong (some leaflet-pane) - I guess, it's was probably set by user. Or am I wrong? The places, which are hardcoded with lat, and Lon are alright. I wanted to check as well how it is with pins, but without working those π Any idea? |
@cesswairimu, I guess I got it. I thought there is bug in the code. Probably we cannot influence what piece of picture (mapshot) any user put together. We can just change it here - I guess it was made by someone 7 years ago, who actually was working on the mapknitter app π I still like to know which file puts together that popup window - I found the separate one solving images on aws s3, but where it grabs that title, author etc. I know it uses some library but still I want to know more :) This is under map So, then it looks like as above picture on the Nairobi hardcoded coordinates: |
What happened just before the problem occurred
I opened up mapknitter website and explored the map πΊοΈ of Nairobi city in Kenya π°πͺ .
When clicked on the pin/marker π it shows picture with title, location, lat and longitude.
Problem/suggestion when you check the printscreen below the
location
doesn't correspond to thelat
andlon
- show Paris instead of Nairobi.Would not be nice to have some check whether location actually belongs to the coordinates? π
Relevant URLs
https://mapknitter.org/#13/-1.2362/36.8301/
PublicLab.org username
(to help reproduce the issue)
Browser, version, and operating system
Mac OS, Safari, Chrome
For bug reports, fill out the above template; for feature requests, you can delete the template.
The text was updated successfully, but these errors were encountered: