Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jasmine test failures stopping progress #721

Closed
jywarren opened this issue May 22, 2021 · 3 comments
Closed

Jasmine test failures stopping progress #721

jywarren opened this issue May 22, 2021 · 3 comments
Labels
Milestone

Comments

@jywarren
Copy link
Member

Unfortunately, and unrelated to #683, we're seeing test errors blocking several/all PRs, including:

#716 #710

Hmm. I'm seeing a lot of this type of error:

   - adds value to 'tags' key of editor.data, instead of overwriting it...
log: Failed to load resource: net::ERR_FILE_NOT_FOUND
   ...adds value to 'tags' key of editor.data, instead of overwriting it...X
     Expected '' to be 'cool,rad'. (1)
>> Expected '' to be 'cool,rad'. Error: Expected '' to be 'cool,rad'.
>>     at <Jasmine>
>>     at UserContext.<anonymous> (file:///home/runner/work/PublicLab.Editor/PublicLab.Editor/spec/javascripts/tags_module_spec.js:32:28)
>>     at <Jasmine>
     Expected 'first,' to be 'first,cool,rad'. (2)
>> Expected 'first,' to be 'first,cool,rad'. Error: Expected 'first,' to be 'first,cool,rad'.

I wonder... near the top i see:

log: Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.

Oddly, other recent pull requests don't show this. #718

@jywarren jywarren added the bug label May 22, 2021
@jywarren jywarren pinned this issue Oct 5, 2021
@jywarren jywarren changed the title Test failures stopping progress Jasmine test failures stopping progress Oct 5, 2021
@jywarren jywarren added this to the v3.1 milestone Oct 5, 2021
@jywarren
Copy link
Member Author

Also noting Jasmine tests overall are stalled: #741

@jywarren
Copy link
Member Author

Let's consider fixing via #743

@jywarren
Copy link
Member Author

jywarren commented Feb 1, 2022

Solved in #818!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant