Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File upload progress to be reflected in UI #2302

Closed
msharp19 opened this issue Sep 1, 2020 · 17 comments
Closed

File upload progress to be reflected in UI #2302

msharp19 opened this issue Sep 1, 2020 · 17 comments
Labels
feature request A request for a new feature.

Comments

@msharp19
Copy link

msharp19 commented Sep 1, 2020

If you drag and drop large files via the file manager, you are only presented with a loading cursor.

This is fine for small file transfer but when it comes to large file transfer (which takes a varying amount of time) it would be nice to see the upload progress.

If you ask me it would be good to see the progress bar/percentage uploaded regardless of the file size but that's up to you!

Thanks!

@schrej schrej added 1.0 🦈 feature request A request for a new feature. labels Sep 1, 2020
@ghost
Copy link

ghost commented Sep 13, 2020

Isn't there a feedback provided by the browser? Such as the one seen here.

image

I'm not saying it's a replacement to a good, satisfying progress bar, but it might not be as important.

@msharp19
Copy link
Author

Hi danielnaaman - not that I can see on Chrome (just tested again to be sure)

@ghost
Copy link

ghost commented Sep 13, 2020

Hi danielnaaman - not that I can see on Chrome (just tested again to be sure)

Odd, I noticed it many times in the past.

I switched to Safari so I can't test it out myself, but since it does only work in Chrome so it's not a viable solution either ways.

Forget I said anything.

@kakduman
Copy link

I relied on this feature a lot when I was uploading new paper jars, and I think it'd make a great addition to the 1.0 panel if it was re-implemented

@LoneDev6
Copy link

Isn't there a feedback provided by the browser? Such as the one seen here.

image

I'm not saying it's a replacement to a good, satisfying progress bar, but it might not be as important.

Sadly nope, using Firefox.
Currently uploading a 500MB file and it would be very nice to see how much time it remains and the upload speed.
Thanks all!

immagine

@matthewpi
Copy link
Member

File upload progress is only shown by the browser if it is submitted using an HTML form which we don't use.

@FoksVHox
Copy link
Contributor

File upload progress is only shown by the browser if it is submitted using an HTML form which we don't use.

So that means that this isn't possible? Or could you maybe explain it a bit more in-depth?

@matthewpi
Copy link
Member

File upload progress is only shown by the browser if it is submitted using an HTML form which we don't use.

So that means that this isn't possible? Or could you maybe explain it a bit more in-depth?

No, it's possible but we would have to handle it manually, similarly to how 0.7 did it. But unlike other sites where you see upload progress in the bottom left (like when you hover over a link), that is handled by the browser itself.

@LoneDev6
Copy link

To get a more noob proof panel I think that is a must have, users may complain with the hosting service if they see no apparent progress.

This is just a suggestion, feel free to accept it considering if it's difficult or not to implement

@DaneEveritt
Copy link
Member

Its always possible, I just don't have the motivation or desire to build such a thing right now, which is why the issue is just sitting with a label.

@FoksVHox
Copy link
Contributor

File upload progress is only shown by the browser if it is submitted using an HTML form which we don't use.

So that means that this isn't possible? Or could you maybe explain it a bit more in-depth?

No, it's possible but we would have to handle it manually, similarly to how 0.7 did it. But unlike other sites where you see upload progress in the bottom left (like when you hover over a link), that is handled by the browser itself.

Thanks for clarifying that.

@VottusCode
Copy link
Contributor

Its always possible, I just don't have the motivation or desire to build such a thing right now, which is why the issue is just sitting with a label.

This was a feature I really needed, especially because we update our servers frequently and there's 1-2 files that are around 100MB, so seeing the progress is a nice touch.

I've had the chance to play around with the frontend and implemented it inside of UploadButton. It currently looks like this

unknown

If you want, I can make a PR for it.

@ShioGa
Copy link

ShioGa commented Aug 13, 2021

Hello, I am French server host, I do not know if the translation is good because I use Google Translation. I would like to know if there is way to know how to do that, because my clients and I send us a lot of files to the server via the file explorer. I would like to know if there was a way to get file back and explain and put it in the server for it to work.

Thank you in advance ^^

@trenutoo trenutoo added this to the panel@v2 milestone Aug 16, 2021
@trenutoo
Copy link
Member

Implemented in V2 c6dccc5

image

@matthewpi
Copy link
Member

Implemented in V2 c6dccc5

image

Still a WIP, but it is implemented.

@ShioGa
Copy link

ShioGa commented Aug 16, 2021

How do I install it?

@trenutoo
Copy link
Member

How do I install it?

Pterodactyl V2 is a work in progress and has not been released yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A request for a new feature.
Projects
None yet
Development

No branches or pull requests

10 participants