Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow retrying an installation if it fails #1590

Open
YoshiWalsh opened this issue May 26, 2019 · 5 comments
Open

Allow retrying an installation if it fails #1590

YoshiWalsh opened this issue May 26, 2019 · 5 comments
Labels
feature request A request for a new feature.

Comments

@YoshiWalsh
Copy link

YoshiWalsh commented May 26, 2019

Is your feature request related to a problem? Please describe.
Currently if an installation fails for any reason (e.g. network error, error in install script, unexpected Docker shutdown) the server is placed in an "Install Failed" state. As far as I can tell, the only way out of this is to delete and re-create the server.

This is an inconvenience, especially when you're reinstalling an existing server and now have to copy all the existing data to a new server.

Describe the solution you'd like
When a server is in the Install Failed state, I'd like a "retry" button which has the exact same functionality as the usual Manage > Reinstall Server option.

Describe alternatives you've considered
Maybe just make the whole Manage tab available while a server is in the Install Failed state? This would allow rebuilding the container and toggling the install state too.

Additional context
Probably another feature request, but it'd be really nice to have a GUI way of viewing the output of server install scripts.

@parkervcp
Copy link
Member

The problem is that a failed install is usually due to an install script not handling the "reinstall" correctly.

This is that it didn't clean up after itself or something else. I.E. it can't extract over files due to files already being there.

@parkervcp
Copy link
Member

This means that just clicking "retry" would cause it to fail again generally.

Most people have done exactly this in the past when the "toggle install status" button existed.

@YoshiWalsh
Copy link
Author

YoshiWalsh commented May 26, 2019

A reinstall script could fail for those reasons, but then after correcting the egg it would be nice to be able to retry. Also transient issues could've caused the installation failure.

There's no harm in giving people an option to retry. If they retry and it still doesn't work they should realise it's not going to work. But the current situation of having to recreate the server is not ideal.

EDIT: Just a note for anyone else having this issue, you can do this manually editing the panel database so that your server's install status is 1 (instead of 2) and then going Manage > Reinstall Server. But I still want a GUI to do it.

@mayed505
Copy link

Well, When the install fails there's no way to toggle it back to the user can for instance access the databases for instance.
I did notice Paper installations would fail at times when their webserver is down and there is no way of toggling the installation status.

@mayed505
Copy link

mayed505 commented Jun 5, 2019

EDIT: Just a note for anyone else having this issue, you can do this manually editing the panel database so that your server's install status is 1 (instead of 2) and then going Manage > Reinstall Server. But I still want a GUI to do it.

Forgot, You really don't need to edit the database. Once you are on the Install Failed admin page, add /manage in the end and you'll be able to toggle the status just fine ;)

@DaneEveritt DaneEveritt added feature request A request for a new feature. Nodejs Daemon labels Jul 26, 2019
@schrej schrej added this to the [email protected] milestone Aug 4, 2020
@matthewpi matthewpi modified the milestones: [email protected], panel@v2 Jul 28, 2021
@matthewpi matthewpi added this to Backlog Nov 2, 2022
@matthewpi matthewpi moved this to 🆕 New in Backlog Nov 2, 2022
@matthewpi matthewpi moved this from 🆕 New to 🧨 Awaiting release in Backlog Nov 21, 2022
@matthewpi matthewpi moved this from 🧨 Awaiting release to 📋 Backlog in Backlog Nov 21, 2022
@matthewpi matthewpi removed this from the panel@v2 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A request for a new feature.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

6 participants