Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a circular or duplicate task dependency is found, only log them once in console #596

Closed
mountaindude opened this issue Jan 1, 2025 · 0 comments
Closed

When a circular or duplicate task dependency is found, only log them once in console #596

mountaindude opened this issue Jan 1, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@mountaindude
Copy link
Contributor

If the task network is such that a circular loop is detected multiple times (a very valid scenario), it's still better to only list this once.
The same applies to duplicate/identical edges between task network nodes.

Right now the above is printed as they are detected when parsing the task network.

Change so that all detected issues are stored, then de-duplicated and finally sent to the console as warnings.

Current version (4.4.0) looks like this:

2025-01-01T11:14:30.526Z warn: Cyclic dependency detected in task network. Won't go deeper.
2025-01-01T11:14:30.526Z warn:    From task : [07245d8c-b33a-4f92-9c1d-b0661c5ead88] "[ctrl-q task chain 11.1] Reload task of Ctrl-Q reload chain app 1-1"
2025-01-01T11:14:30.526Z warn:    To task   : [6097cf88-5143-4158-9b9b-d918454e4b59] "[ctrl-q task chain 2] Reload task of Ctrl-Q reload chain app 2-1"
2025-01-01T11:14:30.526Z warn: Cyclic dependency detected in task network. Won't go deeper.
2025-01-01T11:14:30.526Z warn:    From task : [07245d8c-b33a-4f92-9c1d-b0661c5ead88] "[ctrl-q task chain 11.1] Reload task of Ctrl-Q reload chain app 1-1"
2025-01-01T11:14:30.526Z warn:    To task   : [6097cf88-5143-4158-9b9b-d918454e4b59] "[ctrl-q task chain 2] Reload task of Ctrl-Q reload chain app 2-1"
2025-01-01T11:14:30.526Z warn: Cyclic dependency detected in task network. Won't go deeper.
2025-01-01T11:14:30.526Z warn:    From task : [6097cf88-5143-4158-9b9b-d918454e4b59] "[ctrl-q task chain 2] Reload task of Ctrl-Q reload chain app 2-1"
2025-01-01T11:14:30.526Z warn:    To task   : [f77fb7f9-4262-43d9-9ca0-459de6e908d0] "[ctrl-q task chain 3] Ext program task chaining"
2025-01-01T11:14:30.526Z warn: Cyclic dependency detected in task network. Won't go deeper.
2025-01-01T11:14:30.526Z warn:    From task : [6097cf88-5143-4158-9b9b-d918454e4b59] "[ctrl-q task chain 2] Reload task of Ctrl-Q reload chain app 2-1"
2025-01-01T11:14:30.526Z warn:    To task   : [f77fb7f9-4262-43d9-9ca0-459de6e908d0] "[ctrl-q task chain 3] Ext program task chaining"
@mountaindude mountaindude added the enhancement New feature or request label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mountaindude