Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name conflict around Request #477

Open
psychon opened this issue Jun 11, 2020 · 0 comments
Open

Name conflict around Request #477

psychon opened this issue Jun 11, 2020 · 0 comments
Labels
P5 Priority Nice-to-have stable API Things that might require API changes

Comments

@psychon
Copy link
Owner

psychon commented Jun 11, 2020

#475 (comment)

One thing that I did realize as a result of this is that the Request enum and the Request trait have a name conflict. We may want to do something about that.

(See also https://github.com/psychon/x11rb/pull/475/files#diff-4307c8bb103ffaff2d8c2b994f287998R35 which uses Request as RequestTrait due to this conflict.)
@psychon psychon added stable API Things that might require API changes P5 Priority Nice-to-have labels Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P5 Priority Nice-to-have stable API Things that might require API changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@psychon