Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix d3 js #1394

Merged
merged 1 commit into from
Mar 27, 2023
Merged

fix d3 js #1394

merged 1 commit into from
Mar 27, 2023

Conversation

whereismyjetpack
Copy link
Contributor

@whereismyjetpack whereismyjetpack commented Mar 27, 2023

we missed a part of the migration guide
https://observablehq.com/@d3/d3v6-migration-guide#pointer

This code is running on a preview branch, but that branch has diverged from main so i am submitting a new PR
https://scholarsphere-ghsa.dsrd.libraries.psu.edu/resources/25001067-5f11-4330-9961-b5bdf02c3386

Copy link
Collaborator

@ajkiessl ajkiessl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@whereismyjetpack whereismyjetpack merged commit d4bea48 into main Mar 27, 2023
@whereismyjetpack whereismyjetpack deleted the fix-d3 branch March 27, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants