Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stopped working again #45

Open
pcause opened this issue Aug 1, 2023 · 37 comments
Open

stopped working again #45

pcause opened this issue Aug 1, 2023 · 37 comments

Comments

@pcause
Copy link

pcause commented Aug 1, 2023

Think it is the cookie stuff. It stopped on one machine a few days ago and I copied the cook cache from another machine and it started working. Now fails on all systems

@appatalks
Copy link

appatalks commented Aug 2, 2023

This does appear to be wider spread than just to this piece of code. In that same thread a user reports a different endpoint as still valid, but requires some adjustment to account for the change in results.

Not sure how long that will last. Seems like Yahoo might be playing around with their APIs.

This image appears when navigating the URL reported in the API_ENDPOINT

{"finance":{"result":null,"error":{"code":"Unauthorized","description":"Invalid Crumb. For Developers - https://bit.ly/yahoo-finance-api-feedback"}}}

Followed by a survey ending with:

Similar to like what they did a few months ago :/
😞

@pstadler
Copy link
Owner

pstadler commented Aug 2, 2023

Here we go. Everything that happened during the last couple of weeks pointed towards this.

@phish0r
Copy link

phish0r commented Aug 8, 2023

Yep. Mine stopped working again as well. Is there a chance we can switch to Google Finance or is that not an option

@pcause
Copy link
Author

pcause commented Aug 10, 2023

there is tickr and from a quick look at code it uses yahoo. it is working. not sure if the code can provide a hint as to what to change to get working again

@phish0r
Copy link

phish0r commented Aug 11, 2023

so I guess we're just waiting at this point to see what yahoo does? there does appear to be some endpoints that are still active, like: https://query1.finance.yahoo.com/v8/finance/chart/AAPL for example. /quote seems to be dead though.

@pstadler
Copy link
Owner

This pretty much sums it up, unfortunately. I‘m looking for alternatives, but haven’t been able to find any so far.

@appatalks
Copy link

I created PR#46 if y'all would like to give that a play with 🐧

@pcause
Copy link
Author

pcause commented Aug 14, 2023

I created PR#46 if y'all would like to give that a play with penguin

seems to be working for me

@phish0r
Copy link

phish0r commented Aug 15, 2023

I created PR#46 if y'all would like to give that a play with penguin

seems to be working for me

I can confirm it's working for me as well.

@g4570n
Copy link

g4570n commented Aug 21, 2023

If it is working, will the PR #46 merge be done?

@pstadler
Copy link
Owner

I‘m honestly not convinced that a request per ticker is a good solution, even if it‘s the only way to make it work. Thoughts?

@realpshev
Copy link

as you say, the only way to make it work. i can live with this versus not having the capability.

@pcause
Copy link
Author

pcause commented Aug 23, 2023

PR #46 needs to add support for NOCOLOR

@appatalks
Copy link

PR #46 needs to add support for NOCOLOR

I see in the original code:

if [ -z "$NO_COLOR" ]; then
  : "${COLOR_BOLD:=\e[1;37m}"
  : "${COLOR_GREEN:=\e[32m}"
  : "${COLOR_RED:=\e[31m}"
  : "${COLOR_RESET:=\e[00m}"
fi

I'll try to find some time to learn how to get that in place :)

@appatalks
Copy link

appatalks commented Aug 23, 2023

@pcause I believe I might have got it. Can you try the latest commit to PR#46 and let me know? 🐧

@pcause
Copy link
Author

pcause commented Aug 23, 2023

in my use case it looks like it works. thanks

@pcause
Copy link
Author

pcause commented Sep 27, 2023

the pr 46 version seems to have stopped working today

@pstadler
Copy link
Owner

it feels like every solution using Yahoo Finance will be short-lived from now on.

@appatalks
Copy link

the pr 46 version seems to have stopped working today

I wonder if it might be location based? At the moment, it is still working for me.
What error are you getting? and I'll see if I can recreate/play with it on my end too :)

@pcause
Copy link
Author

pcause commented Sep 27, 2023

interesting. it worked on my linux system but not wsl2 on windows

@appatalks
Copy link

@pcause sorry I haven't responded in a bit for this, for WSL issue, I am afraid I am not have much success getting my windows & hardware to work with wsl in general to effectively troubleshoot (this is a me issue on my part) :(

@pcause
Copy link
Author

pcause commented Oct 6, 2023

np. figured it out. was the python issue that someone else posted about separately

@appatalks
Copy link

appatalks commented Oct 11, 2023

👋 Team,

I adjusted the script to not use python, and added a check for bc for use with NO_COLOR recommended by @milanico2309

At first I was going to try to stick with python, but then I was worried about users who require python2 and then I was trying to find logic to get around that, tl'dr ... it got messy.

I think its also faster now 🤔

@pcause
Copy link
Author

pcause commented Nov 6, 2023

pr45 version - there is a small bug. then computing the percentage change it should be scale=4. bc will calculate to 4 decimal places and the multiply result will give you a percent and factional percent result with this change.

Is there some way to get a clean version. it is hard to find the latest.

@appatalks
Copy link

👋 @pcause

I have my fork here with the master branch currently what I am running for my day-to-day. (In all openness, I am uncertain if it's bug free, but just let me know and Ill be happy to review)

@pcause
Copy link
Author

pcause commented Nov 6, 2023

the one I have uses bc but that version doesn't. it has:

percentChange=$(printf "%.2f" $(echo "scale=4; (($currentPrice - $previousClose) / $previousClose) * 100" | bc))

(original had scale=2)

seems you changed at some point?

@appatalks
Copy link

Ah yes! I remember now, yes, I was also using bc originally, but I kept running against math'ing errors that I couldn't quite figure out. Ran it through AI and it suggested my issue was something to do with bc and floating-point arithmetic and routing or some other way above my head. The AI made the awk suggestion to use instead and so far 🤞 🤞

@pcause
Copy link
Author

pcause commented Nov 6, 2023

interesting. i've been using the bc version without issues other than the one above.

@appatalks
Copy link

I'd be happy to revert and try that scale=2 variable. Not sure if that was something I tried to adjust when trying to get it to work. Might need a bit of time to play with it.

@pcause
Copy link
Author

pcause commented Nov 6, 2023

not worth the effort. i'll grab your version but stash away the one i'm using

@pstadler
Copy link
Owner

pstadler commented Nov 8, 2023

Here an update you all deserve to hear (after me being pretty quiet for a long while).
I'm not happy with the available workarounds. The only available endpoint makes ticker.sh painfully slow (see #46).
Until another provider comes around which gives some endpoints and data for free, I'm considering this project halted.

@lm2lm2
Copy link

lm2lm2 commented Dec 27, 2023

hello
is it possible to make it work back? :)

@adanhawth
Copy link

adanhawth commented Jan 11, 2024

I appreciate your effort on this, but could you please put a nice, big, juicy banner on the landing page that states, "I'm considering this project halted?"... just so we don't waste people's time. Thanks!

@pstadler
Copy link
Owner

@adanhawth Makes sense. Added.

@lm2lm2
Copy link

lm2lm2 commented Jan 25, 2024

that's sad ; no way or other working project to have a similar tool?
thank you

@andymiller-og
Copy link

I still come here to see if there's any sort of progress or alternative option. I guess not. :-(

@appatalks
Copy link

@andymiller-og 👋
Give this one a try: appatalks/ticker.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants