-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stopped working again #45
Comments
This does appear to be wider spread than just to this piece of code. In that same thread a user reports a different endpoint as still valid, but requires some adjustment to account for the change in results. Not sure how long that will last. Seems like Yahoo might be playing around with their APIs. This image appears when navigating the URL reported in the API_ENDPOINT
Followed by a survey ending with: Similar to like what they did a few months ago :/ |
Here we go. Everything that happened during the last couple of weeks pointed towards this. |
Yep. Mine stopped working again as well. Is there a chance we can switch to Google Finance or is that not an option |
there is tickr and from a quick look at code it uses yahoo. it is working. not sure if the code can provide a hint as to what to change to get working again |
so I guess we're just waiting at this point to see what yahoo does? there does appear to be some endpoints that are still active, like: https://query1.finance.yahoo.com/v8/finance/chart/AAPL for example. /quote seems to be dead though. |
This pretty much sums it up, unfortunately. I‘m looking for alternatives, but haven’t been able to find any so far. |
I created PR#46 if y'all would like to give that a play with 🐧 |
seems to be working for me |
I can confirm it's working for me as well. |
If it is working, will the PR #46 merge be done? |
I‘m honestly not convinced that a request per ticker is a good solution, even if it‘s the only way to make it work. Thoughts? |
as you say, the only way to make it work. i can live with this versus not having the capability. |
PR #46 needs to add support for NOCOLOR |
I see in the original code: if [ -z "$NO_COLOR" ]; then
: "${COLOR_BOLD:=\e[1;37m}"
: "${COLOR_GREEN:=\e[32m}"
: "${COLOR_RED:=\e[31m}"
: "${COLOR_RESET:=\e[00m}"
fi I'll try to find some time to learn how to get that in place :) |
@pcause I believe I might have got it. Can you try the latest commit to PR#46 and let me know? 🐧 |
in my use case it looks like it works. thanks |
the pr 46 version seems to have stopped working today |
it feels like every solution using Yahoo Finance will be short-lived from now on. |
I wonder if it might be location based? At the moment, it is still working for me. |
interesting. it worked on my linux system but not wsl2 on windows |
@pcause sorry I haven't responded in a bit for this, for WSL issue, I am afraid I am not have much success getting my windows & hardware to work with wsl in general to effectively troubleshoot (this is a me issue on my part) :( |
np. figured it out. was the python issue that someone else posted about separately |
👋 Team, I adjusted the script to not use At first I was going to try to stick with python, but then I was worried about users who require I think its also faster now 🤔 |
pr45 version - there is a small bug. then computing the percentage change it should be scale=4. bc will calculate to 4 decimal places and the multiply result will give you a percent and factional percent result with this change. Is there some way to get a clean version. it is hard to find the latest. |
👋 @pcause I have my fork here with the |
the one I have uses bc but that version doesn't. it has: percentChange=$(printf "%.2f" $(echo "scale=4; (($currentPrice - $previousClose) / $previousClose) * 100" | bc)) (original had scale=2) seems you changed at some point? |
Ah yes! I remember now, yes, I was also using |
interesting. i've been using the bc version without issues other than the one above. |
I'd be happy to revert and try that |
not worth the effort. i'll grab your version but stash away the one i'm using |
Here an update you all deserve to hear (after me being pretty quiet for a long while). |
hello |
I appreciate your effort on this, but could you please put a nice, big, juicy banner on the landing page that states, "I'm considering this project halted?"... just so we don't waste people's time. Thanks! |
@adanhawth Makes sense. Added. |
that's sad ; no way or other working project to have a similar tool? |
I still come here to see if there's any sort of progress or alternative option. I guess not. :-( |
@andymiller-og 👋 |
Think it is the cookie stuff. It stopped on one machine a few days ago and I copied the cook cache from another machine and it started working. Now fails on all systems
The text was updated successfully, but these errors were encountered: