Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mention about cookie replay to limitations.md #38

Closed
timoh6 opened this issue Dec 15, 2015 · 2 comments
Closed

Add mention about cookie replay to limitations.md #38

timoh6 opened this issue Dec 15, 2015 · 2 comments
Assignees
Milestone

Comments

@timoh6
Copy link

timoh6 commented Dec 15, 2015

As cookie replay could be a security threat (client replays the same cookie multiple times and discards new cookies set by the application), I suggest we should pay attention to it somehow in the limitations.md.

Maybe add new paragraph "Cookie replay" and mention something like (just a quick suggestion):

It should be pointed out that PSR7Session does not address replay of old cookies. Legitimate client can send previous (old) cookies within the cookie lifetime period.

to make the cookie replay issue stand out better.

I was thinking the Cookie replay paragraph could come right before:

The idea around PSR7Session is that a session is not supposed to be an actual storage for transient client information, but rather be used for the concerns of authentication, authorization and eventually for validation concerns such as CSRF-token validation.

If you want to store frequently-updated or concurrently-updated information inside a session, then PSR7Session is likely not fitting your use-case.

Thus making those two paragraphs be under Cookie replay title and paragraph.

Thoughts?

@Ocramius
Copy link
Member

@timoh6 it shall be done, thanks!

@Ocramius
Copy link
Member

Handled in #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants