Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of unsafe #5

Open
psivesely opened this issue May 23, 2018 · 0 comments
Open

Remove use of unsafe #5

psivesely opened this issue May 23, 2018 · 0 comments

Comments

@psivesely
Copy link
Owner

With upcoming changes in sodiumoxide (sodiumoxide/sodiumoxide#208 and sodiumoxide/sodiumoxide#196), it should be possible to remove use of unsafe from this library.

After these are merged I believe I will actually have to write a follow-up PR that allows direct calls to crypto_generichash where the out argument is &mut [u8]. This will be much more efficient than dealing with the State object defined in https://github.com/sodiumoxide/sodiumoxide/pull/196/files#diff--ca72970d1aef31492c489302609ede1fR30 or any all-in-a-single-call hashing function that doesn't take an out argument (as I can't think of any way of super-efficiently combining the arrays that doesn't include the use of unsafe, which is what we're trying to get rid of in the first place 😺).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant