-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating Windows installer #1
Comments
Hi! I stumbled upon your changes while trying to setup (indeed) CI for the project before releasing any installers. Unfortunately, it seems we did some duplicate work. I too run a Jenkins which is why i created all the scripts in the For windows build, I do have a Windows VM as slave which runs the About |
Your scripts go way beyond my knowledge (currently at least). As I've said earlier, I've very little knowledge about Qt. I haven't tested anything related to DirectX injection. It didn't seem to work on the official application when I tried using it. So instead I'm using different profiles depending on what I'm doing, all based on the Windows API grabber or whatever it's called (different FPS settings because Aero). But if statically linking is needed for that part, then I guess you do have to do some .sln patching. Have you tried using Hmm, I try to run as many things as possible on external CI services, even if I'm the only contributor to my own project. But each their own, I respect that. I don't mind contributing and such, but do I need an account on your Jenkins? Currently I have no idea what I can contribute, except for making a better structure in the project (and a better A Windows slave is what I'm using as well. It's actually a VM that's managed with a modified plugin that boots it up, and shuts it down and reverts it to a previous state afterwards. I really can't afford to have a Windows VM or physical pc running all the time. It's weird that your status is stuck for PRs. I can't help you with that, I tried to link a project to my Jenkins, and that seems to work. But yeah, it's Jenkins. In my opinion it's one messy software that needs to be built up from the ground again. I'm actually quite sad that Woodenshark has no helpful compilation documentation or just generic info about anything. When you release something to the public, in my opinion you should at least get your building steps, etc. right. It took me a day or two to get everything working as I wanted it to be. Sorry for the wall of text, but there was a lot of different points I wanted to respond to. |
To add to
After looking up why it was adding those odd DLLs, I found this:
Regarding It would also seem that the translations in EDIT: Actually, it shouldn't copy the debug DLLs, I'm wondering why it does that now. It didn't do that before. |
I'll try to split it a bit: windeployqt additional libraries CI project setup |
static linking and Win32 in x64 magic windeployqt On a similar note, I just noticed that in https://github.com/psieg/Lightpack/blob/master/Software/src/src.pro#L107-118 it already copies some of the Qt dependencies. I think it would be confusing to copy dependencies at two locations, one from the generated VS project file and one afterwards in a shell script. additional libraries CI project setup |
Since this discussion was mostly about improving the compilation of Prismatik on Windows that's now being discussed in #8, I'll close this. |
Hey there!
I noticed that you based your installers on the changes in my fork. Looks great! In that fork, I only changed some stuff myself to see if I could let my semi-private Jenkins automatically build the installer before Windows 10 will be released (the desktop duplication feature looks very promising, as I'm currently still on Windows 7), but I didn't expect you to take it and improve it.
If I understand correctly, you're building the project for Windows on Linux? Or are you just preparing and packaging stuff on Linux, but building on Windows instead? Either way, I made it working to let it fully build on Windows, although it was a pain. In case you want to try it out, here are my scripts that I'm using on my Jenkins:
Preparing
build-vars.prf
in a suboptimal way (PowerShell) (I'm not even sure why this needs to be created, it seems that some variables are not even used withqmake
):Build
Software\Lightpack.sln
with VS2013.Copy the output to
bin
,windeployqt
it, package it and create an installer as well (also Powershell):Everything that's in the scripts above can definitely be improved, but I just want to show you how I've made it working. Especially
windeployqt
, it can copy the Qt dependencies very easily without you having to copy the Qt DLLs every time manually or with a custom script. Sadly, this also adds some other DLLs that I have no clue about what they do (likeD3Dcompiler_47.dll
,libEGL.dll
,libGLESV2.dll
andopengl32sw.dll
), but they seemed to be needed on my installation. I have very little knowledge about Qt, but it seems to be dependent on which OS or environment you're building Prismatik. That said, I'm currently successfully running my version of the installer on my Windows 7 installation from my fork, not sure about yours though, I haven't tried it.On a similar note, seeing that you pushed a couple of "trigger CI" commits, how are you handling CI? If you're interested, seeing that the official version is not really maintained anymore, what do you think of enabling some public CI services like Travis (Linux) and AppVeyor (Windows)? I have some experience with AppVeyor myself, and you can automatically create and upload artifacts during builds.
The text was updated successfully, but these errors were encountered: