Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional arguments for justl-exec-recipe-in-dir #41

Closed
glucas opened this issue Sep 10, 2023 · 3 comments
Closed

Support optional arguments for justl-exec-recipe-in-dir #41

glucas opened this issue Sep 10, 2023 · 3 comments

Comments

@glucas
Copy link

glucas commented Sep 10, 2023

When executing recipes from the justl buffer you have the option to "execute" or "execute with arguments". It would be great if there were a way to provide additional arguments when using justl-exec-recipe-in-dir. This could be an alternate command (like justl-exec-recipe-in-dir-with-args), but I was thinking you could handle an optional prefix argument.

That way one could bind justl-exec-recipe-in-dir to e.g. C-c j and then use C-u C-c j when additional arguments are needed.

@glucas
Copy link
Author

glucas commented Sep 10, 2023

This seems similar to #30, which is closed but does not seem to work for me. I'm testing with a simple recipe like

test target:
    echo '{{target}}'

and I don't get prompted for target.

Initially I was thinking that #30 worked for required parameters but did not handle optional ones with a default value -- but neither is working for me.

@psibi
Copy link
Owner

psibi commented Sep 13, 2023

I can reproduce the issue too with justl-exec-recipe-in-dir. I am open to receiving pull requests, although I am uncertain if I will have sufficient bandwidth to personally resolve it in near future.

@psibi
Copy link
Owner

psibi commented Nov 15, 2024

Fixed via #62

@psibi psibi closed this as completed Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants