Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

justl-exec-recipe-in-dir doesn't seem to use justl-compile-mode #24

Closed
treed opened this issue Aug 29, 2022 · 5 comments
Closed

justl-exec-recipe-in-dir doesn't seem to use justl-compile-mode #24

treed opened this issue Aug 29, 2022 · 5 comments

Comments

@treed
Copy link

treed commented Aug 29, 2022

I came here to ask for the justl-compile-mode feature and found that it had already been implemented, which is cool!

However, it seems not to work with justl-exec-recipe-in-dir. Perhaps I'm just missing something, but it would be nice to have justl-complie-mode work with both methods of interaction. :)

@psibi
Copy link
Owner

psibi commented Aug 30, 2022

Yeah, good catch. It has been quite some time since I used justl-exec-recipe-in-dir as I have been using the justl way of interacting with it.

This should be relatively simple to fix, I will see if I can get to it soon.

@psibi
Copy link
Owner

psibi commented Aug 30, 2022

Also, if you would want to send a PR, that's welcome too. :-)

@psibi
Copy link
Owner

psibi commented Sep 2, 2022

@treed Can you see if this works for you: #25 ?

@treed
Copy link
Author

treed commented Sep 3, 2022

Yeah, this looks like it works, thanks!

I toyed around with it some but wasn't sure about what to pass for the directory. Glad to know I was on the right track at least.

@psibi
Copy link
Owner

psibi commented Sep 3, 2022

Thanks for the confirmation!

@psibi psibi closed this as completed Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants