Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only justfile filename is recognized #13

Closed
bram85 opened this issue Mar 9, 2022 · 9 comments
Closed

Only justfile filename is recognized #13

bram85 opened this issue Mar 9, 2022 · 9 comments

Comments

@bram85
Copy link

bram85 commented Mar 9, 2022

just detects a justfile without regarding the case (so also accepts Justfile, JUSTFILE, etc.) and even .justfile if you want to hide it.

justl only recognizes 'justfile', so it would be nice if both tools perform the same lookup mechanism.

@psibi
Copy link
Owner

psibi commented Mar 10, 2022

Yeah, I agree this is a issue.

and even .justfile

I think this mode supports .justfile fine (Ref:

(let ((dot-justfile-path (justl--find-any-justfiles dir ".justfile")))
) That doesn't work for you ?

@bram85
Copy link
Author

bram85 commented Mar 10, 2022

Yes, .justfile does work for me.

I wrote the issue with the 'just' README on one side and only seeing the hardcoded 'justfile' on the other side, assuming only 'justfile' is supported.

Then all is left is the case insensitive matching.

@psibi
Copy link
Owner

psibi commented Mar 10, 2022

Cool, thanks for the confirmation. :-)

@psibi
Copy link
Owner

psibi commented Mar 10, 2022

@bram85 Can you give this a try: #14 ?

@bram85
Copy link
Author

bram85 commented Mar 10, 2022

Yes seems to work ok, thank you.

@psibi
Copy link
Owner

psibi commented Mar 11, 2022

Cool. Fixed via #14

@psibi psibi closed this as completed Mar 11, 2022
@failable
Copy link

Is the support for .justfile drop? The current code seems to find justfile only.

((is-justfile (s) (string= "justfile" (downcase s)))

@psibi
Copy link
Owner

psibi commented Feb 17, 2024

@liebkne Don't think that was intentional, PRs welcome.

@psibi psibi reopened this Feb 17, 2024
@psibi
Copy link
Owner

psibi commented Nov 15, 2024

Fixed via #63

@psibi psibi closed this as completed Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants