Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5677: Rebuild proxies on Session#send #5681

Merged
merged 1 commit into from
Jan 24, 2021
Merged

5677: Rebuild proxies on Session#send #5681

merged 1 commit into from
Jan 24, 2021

Conversation

mateusduboli
Copy link
Contributor

  • Adds some test cases to highlight the issue, some of those seem excessive, I would like suggestions on how to combine them.
  • Rebuilds the proxy configuration on send, making it behave like requests.Session#request that already did that.

@mateusduboli mateusduboli changed the title #5677: Rebuild proxies on Session#send 5677: Rebuild proxies on Session#send Dec 8, 2020
sigmavirus24
sigmavirus24 approved these changes Jan 24, 2021
View reviewed changes
requests/sessions.py Show resolved Hide resolved
@sigmavirus24 sigmavirus24 merged commit 8c211a9 into psf:master Jan 24, 2021
@mateusduboli mateusduboli deleted the 5677 branch January 28, 2021 17:46
@CrazyBoyFeng CrazyBoyFeng mentioned this pull request Mar 5, 2021
Open
1 task
@mateusduboli mateusduboli mentioned this pull request Mar 8, 2021
Open
@nateprewitt nateprewitt mentioned this pull request Jul 9, 2021
Merged
@nateprewitt nateprewitt mentioned this pull request Jul 27, 2021
Closed
@omermizr omermizr mentioned this pull request Jul 28, 2021
Closed
@nateprewitt nateprewitt mentioned this pull request Aug 12, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sigmavirus24 sigmavirus24 sigmavirus24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateusduboli @sigmavirus24