Set Docker to use 3.11 for now #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until we get new aiohttp wheels we need to build with 3.11. You can see an example of a fail here: Workaround for #3919 - Will leave it open until we can move to 3.21
JelleZijlstra
approved these changes
Oct 6, 2023
I will remind you in 2033. |
|
haha - Good call ... I'll prob be dead in 2033. I also noticed we don't compile black in the docker container. I guess we should :) I'll open a dedicated issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we get new aiohttp wheels we need to build with 3.11. You can see an example of a fail here:
Workaround for #3919 - Will leave it open until we can move to 3.12
EDIT: Forgot to add I ran this locally on my box from the root of the black repo:
docker build -t black_test --network host .