Add mypyc test marks to new tests that patch #3871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is enough for me to get a clean test run on Python 3.9 with mypyc. I have not been able to repro the pickle failures on either Linux or macOS.
hauntsaninja
added
the
skip news
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is enough for me to get a clean test run on current main with Python 3.9 with mypyc.
This is needed for the usual reason that mypyc doesn't like monkeypatching.
I'd say we should merge this even if we merge #3870 , because it would be nice to completely undo that PR.
I have not been able to repro the pickle failures on either Linux or macOS, note those also happen on tests other than these ones.