PS2 fluidsynth #1
Conversation
Better fix for FluidSynth#1305
Fixes the 16 software supply chain safety warnings at the bottom right of https://github.com/FluidSynth/fluidsynth/actions/runs/8767406884 * [Keeping your actions up to date with Dependabot](https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot) * [Configuration options for the dependabot.yml file - package-ecosystem](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem)
Keep GitHub Actions up to date with GitHub's Dependabot
Bumps the github-actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [github/codeql-action](https://github.com/github/codeql-action). Updates `actions/checkout` from 3 to 4 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) Updates `github/codeql-action` from 2 to 3 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]>
…actions/github-actions-67979dcedc Bump the github-actions group with 2 updates
|
I think it is better to keep those changes as minimal as possible, as it will help us to update dependency in the future |
|
|
||
| #include <stdbool.h> | ||
|
|
||
| int pthread_atomic_int_get(const volatile int *atomic); |
There was a problem hiding this comment.
I know that currently EE toolchain doesn't support atomic library, however, we still have the headers, can't we just keep the names and implement those methods with the same implementation you did with pthread?
It will avoid you the change in this header
CMakeLists.txt
Outdated
| @@ -370,6 +406,14 @@ endif ( HAS_LIBM ) | |||
|
|
|||
| set ( LIBFLUID_LIBS ${MATH_LIBRARY} Threads::Threads ) | |||
|
|
|||
| unset ( PS2DEV_LIBS CACHE) | |||
| if ( PS2 ) | |||
There was a problem hiding this comment.
Why are these specific changes being needed?
Remove messy and unnecessary PS2 code.
There was a problem hiding this comment.
Instead of removing the lash support is not easier just to set the “LASH_SUPPORT” variable?
Keep in mind the less change we do to the mainstream the easier will be to perform updates in the future.
Do you want me to update branch? I see several changes in workflows totally unrelated to the PS2 port…
Thanks again for your effort
I agree i will do a port fluidsynth ee-sans-glib port from scratch |
Go ahead. At least till @Wolf3s does a port of fluidsynth ee-sans-glib port from scratch. |
No description provided.