Fails with non-Youtube sites

[sjelfull]

When I try to do .getInfo for an Vimeo video, it fails. Even though you mention in the readme that this supports many more sites (like youtube-dl itself does), it looks like yours isn't made to work with any other sites.

Two places where I know it messes up is on line 95, where it defaults to http://www.youtube.com/watch?v= if a playlist isn't detected, and when that is fixed, the parsing of info doesn't seem to work.

I'm testing against the Vimeo video https://vimeo.com/6586873

[fent]

Added a test for this.

https://github.com/fent/node-youtube-dl/blob/master/test/getInfo.js#L30

[sjelfull]

Ah, thanks for being quick. I was just about to submit a pull request.

[kminek]

just downloaded and tested above vimeo url - still the problem occurs for me (windows environment):

{ [Error: Command failed: WARNING: Falling back on generic information extractor . ERROR: Unsupported URL: https://www.youtube.com/; please report this issue on ht tps://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and inc lude its complete output. Make sure you are using the latest version; type yout ube-dl -U to update. ] killed: false, code: 1, signal: null }

[fent]

The tests still pass, and the differences with Windows doesn't affect how it behaves for other non-youtube sites.

[kminek]

well this is odd... i am using following script: https://gist.github.com/anonymous/deb88e12fa3aa7620d61
and it fails with above error. when invoking python script (inside bin dir) via python youtube-dl --skip-download --dump-json https://vimeo.com/6586873 it returns data...

[fent]

Can you print what opt is after this line

https://github.com/fent/node-youtube-dl/blob/master/lib/youtube-dl.js#L98

[kminek]

https://gist.github.com/kminek/2adbca3f6bea69046659

looks like url is not passed correctly

[fent]

I can't figure out why it would get up to that point with those variables. It looks like if it's not a youtube url, by checking isYoutubeRegex, then it doesn't prepend the youtube part.

[kminek]

ok i think i found problem, it looks like the version installed via npm is older and does not contain fix in this ticket :) putting "youtube-dl": "git://github.com/fent/node-youtube-dl.git#master" in package.json solves problem :)

[fent]

Oh, it looks like I forgot to npm publish that fix. Sorry, will do that soon.