Listen to all Network Interfaces for discovery #7434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazdagi
previously approved these changes
Oct 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #7434 +/- ##
=======================================
Coverage 60.07% 60.07%
=======================================
Files 424 424
Lines 30325 30325
=======================================
Hits 18219 18219
Misses 9115 9115
Partials 2991 2991 |
This reverts commit a5d6fff.
This reverts commit b7a0cf5.
This reverts commit 57e6218.
…geth-sharding into listenToAllIfaces
farazdagi
previously approved these changes
Oct 6, 2020
…geth-sharding into listenToAllIfaces
prestonvanloon
previously approved these changes
Oct 7, 2020
|
I think this is failing e2e tests. |
farazdagi
reviewed
Oct 8, 2020
Co-authored-by: Victor Farazdagi <[email protected]>
farazdagi
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Improvement
What does this PR do? Why is it needed?
This PR defaults to listening to all network interfaces for discovery. Previously we would only bind to a single
interface however that caused issues with virtual networks where that was less straightforward. So a solution
there was to instead determine which network interface a node would bind to when sending out an outbound
packet using UDP as the transport. This however lead to issues with nodes running with dynamic IPs, as
on each IP reset the network interface to bind to would also have changed. This PR instead simply
binds to all interfaces so as to solve issues with network disconnections/resets.
Which issues(s) does this PR fix?
Fixes #7383 , Resolves #7220
Other notes for review