Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aligning ETH2.0 spec - Make Epoch First Citizen (Shuffling and GetCrosslinkAtSlot) #1488

Merged
merged 5 commits into from
Feb 5, 2019
Merged

Aligning ETH2.0 spec - Make Epoch First Citizen (Shuffling and GetCrosslinkAtSlot) #1488

merged 5 commits into from
Feb 5, 2019

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Feb 4, 2019 •
edited
Loading

This is part of #1449

Key changes in this PR:

  • Updated Shuffling function
  • Updated GetCrosslinkAtSlot
  • Used params.BeaconConfig() instead of config
  • Update all the tests

@terencechain terencechain self-assigned this Feb 4, 2019
@terencechain terencechain changed the title [WIP ]Aligning ETH2.0 spec - Make Epoch First Citizen (Shuffling and GetCrosslinkAtSlot) Aligning ETH2.0 spec - Make Epoch First Citizen (Shuffling and GetCrosslinkAtSlot) Feb 5, 2019
@terencechain terencechain mentioned this pull request Feb 5, 2019
Merged
3 tasks
prestonvanloon
prestonvanloon approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment about a magic 16. Please use a constant so it is clear what this number represents.

beacon-chain/core/balances/rewards_penalties_test.go Outdated
@@ -205,10 +205,14 @@ func TestInclusionDistRewards_Ok(t *testing.T) {
ExitEpoch: config.FarFutureEpoch,
}
}
var participationBitfield []byte
for i := 0; i < 16; i++ {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is 16?

@prestonvanloon prestonvanloon added this to the Sapphire milestone Feb 5, 2019
@terencechain terencechain merged commit 506db55 into master Feb 5, 2019
@nisdas nisdas deleted the align-2.0-crosslinkAtSlots branch April 20, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

Assignees

@terencechain terencechain

Labels
None yet
Projects
None yet
Milestone
Sapphire
Development

Successfully merging this pull request may close these issues.
2 participants
@terencechain @prestonvanloon