Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning ETH2.0 spec - Make Epoch First Citizen (Package: Committee) #1477

Merged
merged 18 commits into from
Feb 4, 2019

Conversation

terencechain
Copy link
Member

This is part of #1449, please review #1460 first.

Key changes in this PR:

  • Updated committee helpers. They are now tracking epoch instead of tracking slot
    • get_epoch_committee_count
    • get_current_epoch_committee_count
    • get_previous_epoch_committee_count
    • get_next_epoch_committee_count
  • Fixed tests to align with new helpers
  • Misc config changes

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #1477 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1477   +/-   ##
=======================================
  Coverage   72.51%   72.51%           
=======================================
  Files         102      102           
  Lines        6652     6652           
=======================================
  Hits         4824     4824           
  Misses       1440     1440           
  Partials      388      388

@rauljordan rauljordan merged commit 720c80d into master Feb 4, 2019
@rauljordan rauljordan deleted the update-committee-helpers branch February 4, 2019 21:27
@prestonvanloon prestonvanloon added this to the Sapphire milestone Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants