Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork choice filter viable branches #4137

Closed
terencechain opened this issue Nov 27, 2019 · 3 comments
Closed

Fork choice filter viable branches #4137

terencechain opened this issue Nov 27, 2019 · 3 comments
Labels
Blocked Blocked by research or external factors

Comments

@terencechain
Copy link
Member

We have been seeing head state reverts to older finalized epochs. This is due to discrepancy in fork choice branch filter. Since the validators use the state at the head to cast votes, but fork choice uses latest check points to advance. There's an edge case when the two go out of band.

The solution for is under research and can be tracked: ethereum/consensus-specs#1495
@terencechain terencechain added the Blocked Blocked by research or external factors label Nov 27, 2019
@prestonvanloon prestonvanloon mentioned this issue Nov 28, 2019
Closed
@prestonvanloon
Copy link
Member

Research topic has merged. ethereum/consensus-specs#1495

@terencechain
Copy link
Member Author

Waiting for official v0.9.3 release: ethereum/consensus-specs#1507

Here's a few more fixes we should take in as well:
ethereum/consensus-specs#1508
ethereum/consensus-specs#1509
ethereum/consensus-specs#1510

@terencechain
Copy link
Member Author

Addressed in #4272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocked Blocked by research or external factors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prestonvanloon @terencechain