Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mega Tracking] Align Codebase to Spec v0.1 #1449

Closed
terencechain opened this issue Jan 31, 2019 · 3 comments
Closed

[Mega Tracking] Align Codebase to Spec v0.1 #1449

terencechain opened this issue Jan 31, 2019 · 3 comments
Assignees
@terencechain
Labels
Priority: High High priority item
Milestone
Sapphire

Comments

@terencechain
Copy link
Member

terencechain commented Jan 31, 2019 •
edited
Loading

This issue tracks the overall progress of updating the current codebase to spec v0.1 and this commit

As part of the test net deliverable, we should lock down on a spec version before hardening. v0.1 sounds like a good candidate given the end of Q1 is 2 months away.
@terencechain terencechain added the Priority: High High priority item label Jan 31, 2019
@terencechain terencechain changed the title Align Codebase to Spec v0.1 [Mega Tracking] - Align Codebase to Spec v0.1 Jan 31, 2019
This was referenced Jan 31, 2019
Merged
Merged
Merged
Merged
@terencechain terencechain self-assigned this Feb 2, 2019
@terencechain terencechain mentioned this issue Feb 3, 2019
Merged
@prestonvanloon prestonvanloon mentioned this issue Feb 3, 2019
Merged
This was referenced Feb 4, 2019
Merged
Merged
@nisdas nisdas mentioned this issue Feb 5, 2019
Merged
9 tasks
@nisdas
Copy link
Member

nisdas commented Feb 5, 2019

Changes I will be handling:
validator_registry_update_slot to validator_registry_update_epoch
remove validator_registry_delta_chain_tip_hash32
previous_epoch_calculation_slot to previous_calculation_epoch
current_epoch_calculation_slot to current_calculation_epoch
previous_justified_slot to previous_justified_epoch
justified_slot to justified_epoch
finalized_slot to finalized_epoch
Fix references for all these changes
Fix tests to account for the changes

@prestonvanloon prestonvanloon added this to the Sapphire milestone Feb 5, 2019
This was referenced Feb 5, 2019
Merged
Merged
Merged
Merged
@prestonvanloon prestonvanloon pinned this issue Feb 6, 2019
@rauljordan rauljordan mentioned this issue Feb 6, 2019
Merged
@terencechain terencechain mentioned this issue Feb 6, 2019
Merged
@terencechain terencechain changed the title [Mega Tracking] - Align Codebase to Spec v0.1 [Mega Tracking] Align Codebase to Spec v0.1 Feb 7, 2019
This was referenced Feb 7, 2019
Merged
Merged
Merged
Merged
Merged
Merged
@terencechain
Copy link
Member Author

We can close this as soon as #1523, #1537, #1539, and #1540 gets merged
We'll use #1541 and #1542 to track anything after

@terencechain terencechain unpinned this issue Feb 9, 2019
@terencechain
Copy link
Member Author

Can close this. Please refer #1541 and #1542 for the next set of issues

@terencechain terencechain mentioned this issue Feb 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terencechain terencechain

Labels
Priority: High High priority item
Projects
None yet
Milestone
Sapphire
Development

No branches or pull requests
3 participants
@prestonvanloon @terencechain @nisdas