Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update differences between code and help commands #14275

Closed
peko-hr opened this issue Jul 30, 2024 · 5 comments · Fixed by #14334
Closed

Update differences between code and help commands #14275

peko-hr opened this issue Jul 30, 2024 · 5 comments · Fixed by #14334
Labels
Bug Something isn't working Good First Issue Good for newcomers

Comments

@peko-hr
Copy link

peko-hr commented Jul 30, 2024

Describe the bug

Description

  • The actual source code and the behavior of the help command are different and need to be updated to avoid confusion.

MaxBuilderEpochMissedSlots = &cli.IntFlag{
Name: "max-builder-epoch-missed-slots",
Usage: "Number of total skip slot to fallback from using relay/builder to local execution engine for block construction in last epoch rolling window",
}

To make it more friendly, Value should be included.
This should also be reflected in the official documentation.

🔬 Minimal Reproduction

  1. Build Prysm. (Docker is also acceptable)
  2. Show help command
  3. Check max-builder-epoch-missed-slots

Platform(s)

Linux (x86), Mac (Apple Silicon)

What version of Prysm are you running? (Which release)

v5.0.3

@peko-hr peko-hr added the Bug Something isn't working label Jul 30, 2024
@peko-hr
Copy link
Author

peko-hr commented Jul 30, 2024

The number to be defined is 5.
Is the number 5 appropriate?

MaxBuilderEpochMissedSlots: 5,

@james-prysm james-prysm added the Good First Issue Good for newcomers label Jul 30, 2024
@bnovil
Copy link
Contributor

bnovil commented Aug 12, 2024

Is anyone working on it ?

@aminlatifi
Copy link

@peko-hr it has the "Good First Issue" label, fortunately. I am a new comer like to contribute to this project, may I pick it up?

@peko-hr
Copy link
Author

peko-hr commented Aug 26, 2024

@aminlatifi

Of course, please.
Is there anything I can do?

@aminlatifi
Copy link

@peko-hr My bad, it seems it's already addressed in #14334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Good First Issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants