Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for to clipper::union without enough offset #6451

Closed

Conversation

supermerill
Copy link
Contributor

with prusaslicer 2.3.1:
If I try to slice this object with a modifier:
clipper_error_test.zip
then some extremely tiny holes are created and ruin the print
I've created this pullrequest to repair this error
It allow clipper::union to not add extremely small holes if called with safety_offset
It check that all polygons are all thicker than scaled_epsilon
It may be a bit costly.. i don't know by how much vs the union. It may use more int and less double with some careful refactoring...

It check that all polygons are all thicker than scaled_epsilon
@bubnikv
Copy link
Collaborator

bubnikv commented Apr 29, 2021

The issue is caused by slice simplification.

// Simplify slices if required.
if (m_print->config().resolution)
    this->simplify_slices(scale_(this->print()->config().resolution));

@bubnikv
Copy link
Collaborator

bubnikv commented Jun 4, 2021

Fixed by refactoring the slicing algorithm vs. xy offset compensation order.
Thanks for pointing out the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants