Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successfully ejected storage device popup should not be modal #4821

Closed
JS3910 opened this issue Oct 3, 2020 · 1 comment
Closed

Successfully ejected storage device popup should not be modal #4821

JS3910 opened this issue Oct 3, 2020 · 1 comment

Comments

@JS3910
Copy link

JS3910 commented Oct 3, 2020

Version

2.2.0+ release version.

Operating system type + version

Mac OS 10.15.6

Behavior

When unmounting a storage device with the eject button in the lower right corner, a succesful unmount pops up a modal dialog. This popup is almost identical to the error message that appears when unmounting fails.

Message box when ejecting is successful
Screen Shot 2020-10-03 at 11 47 01

Essentially identical message when unmounting fails
Screen Shot 2020-10-03 at 11 49 16

Remember, a modal dialog should only be used when the system absolutely cannot continue to function, or would not function in a desirable way without user interaction. The desired behavior in this case would be for the software to not block user input and wait for a dialog dismissal when the requested action is performed succesfully. More acceptable solutions can include some or all of:

  • Small non-modal balloon popup in the bottom right corner where you just clicked, acknowledging success
  • Eject button getting grayed out
  • Eject button getting hidden
  • (not ideal) same popup as now but clicking anywhere on the screen dismisses it

Is this a new feature request?
Low-hanging fruit improvement.

@lukasmatena
Copy link
Collaborator

This is already solved in current master, the dialog was replaced by non-modal notification similar to the one I posted in #4606 (comment). The 2.3.0-alpha1 release should be out in a week, you can have a look.

I'm closing the issue. If you're unhappy with the solution in the alpha, let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants