Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infill with transparent materials #19

Closed
KoKuToru opened this issue Nov 6, 2016 · 2 comments
Closed

Infill with transparent materials #19

KoKuToru opened this issue Nov 6, 2016 · 2 comments
Labels
enhancement improve an existing feature or functionality in the software infill

Comments

@KoKuToru
Copy link

KoKuToru commented Nov 6, 2016

Version

89cf290

Operating system type + version

Linux (ArchLinux)

Behavior

  • Printing transparent material with infill is ugly
  • Steps needed to reproduce the problem
    • Print with transparent material
    • Check visual
  • Expected Results
    • bildschirmfoto von 2016-11-06 13-43-17
  • Actual Results
    • bildschirmfoto von 2016-11-06 13-41-42

Is this a new feature request?
Probably yes


Why is the expected result better for transparent materials ?
Because it doesn't change the width of the perimeter.

How was the expected result screenshot generated ?
I quickly hacked some values..
FillRectilinear2.cpp@1324: bool skip = true and
FillRectilinear2.cpp@1386: bool skip = true
That said, it looked like I might be able to get this behavior by changing the link_max_length value somehow.. (but 0 is not allowed)

I might be able to create a patch for this...
I suppose emit_perimeter_segment_on_vertical_line and emit_perimeter_prev_next_segment generate these perimeter lines.. just need to check how to make them conditional by a config parameter.. (but do the perimeter lines for solid infills)


If the original slic3r-repro is better for this issue.. let me know I will recreate it there..
But i think the infill code here is different then the one in the original slic3r-repro..

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 6, 2016

As commented in the pull request, link_max_length shall be set to a small but nonzero value to effectively diable the infill lines fusing with the inner perimeters.

If the original slic3r-repro is better for this issue.. let me know I will recreate it there..
But i think the infill code here is different then the one in the original slic3r-repro..

The rectilinear / grid infills are completely rewritten in the Prusa3D fork, the triangle and cubic infillls are new in the prusa3d fork.

@JohnnyDeer
Copy link

This problem has already been solved. I will close this issue in framework of improving the clarity of the issues list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve an existing feature or functionality in the software infill
Projects
None yet
Development

No branches or pull requests

3 participants