typo: unload is déchargé not chargé in french #3860
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of redscreen, printer would show BSOD because it failed to write error to usb serial. So writes to USB-CDC are skipped from ISR. Its not possible to acquire mutex to write to USB from ISR, and even if it would be somehow implemented, it wouldn't probably flush the message in time anyway.
…zle offset calibration
If one dwarf finished much earlier than another, it would reset the PID and the other would fail the test. BFW-4607
It was migrating p=17 which was default at that time, but never used. Now the default is 14 and will follow the default if we want change.
If ISR would happen during that function, the crash_s.loop would stay true during the loop when crash_s.set_state(Crash_s::RECOVERY) is set.
This reverts commit fb4e117.
Handle unexpected dirs (blocking the uploaded file) and missing destination dirs in a better way than just "Unknown error". BFW-4543.
* Use 5 retries in a row. * Reset back to 5 when we make some progress. BFW-4547.
Apparently, our remove & stuff didn't report EISDIR properly. We go with stat instead of fopen to figure stuff out. BFW-4147.
When we have a download failure, back up the position before retrying so we don't lose any data unnecessarily. Slightly related to BFW-4647 (that one made it more observable for some reason).
Code unification & simplification ‒ create a transfer in a "failed" state and "retry" it later. Apart from making the code shorter and less duplicate, it also makes sure the download order is initialized before the first request (needed for future commits). (The code was duplicated for historical reasons ‒ originally, Download could fail at startup; this is no longer possible) BFW-4647.
The variant of construction with a destination path is no longer used, remove from the code. As a result, the initialization can't fail ‒ it can become a constructor directly. BFW-4647.
Change the order of downloading textual gcodes from header -> tail -> body to tail -> header + body (the latter one being in one chunk). We need both the header and tail before we start the print, but we don't care in which order we get them. This way we save one request (one seek) ‒ cheaper for us, cheaper for the server and likely few seconds faster before the print starts. BFW-4647.
To postpone a closure until the end of a scope / turn a closure into RAII.
To be used on reprint button when we want toolmapping screen to show. BFW-4568
We don't have consent from the user right now and they are not encrypted. Shouldn't go to "production". BFW-3468.
Add MINI+ and MK3.9 to the list of supported models.
…better gcode debugging
|
Hi, thanks for your contribution, but this is already integrated into PR #3089, so you can close your PR. Thanks ! |
|
Closing this in favor of #3089 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In french unload is "déchargé", "chargé" means load. It gives me headache the first time i tryed to change filament while printing.