From d505642df1fc9d3c5e593c1e3b43ed1a971bdb2a Mon Sep 17 00:00:00 2001 From: Martijn Stevenson Date: Thu, 10 Oct 2024 05:56:28 +0000 Subject: [PATCH] Fix dupe linker opt, add TODO for Docker builds Signed-off-by: Martijn Stevenson --- bazel/defs.bzl | 1 - sdk_container.sh | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/bazel/defs.bzl b/bazel/defs.bzl index 62bac57..3bebe9b 100644 --- a/bazel/defs.bzl +++ b/bazel/defs.bzl @@ -95,7 +95,6 @@ def proxy_wasm_cc_binary( linkopts = linkopts + [ "--no-entry", "--js-library=$(location @proxy_wasm_cpp_sdk//:proxy_wasm_intrinsics_js)", - "-sSTANDALONE_WASM", "-sEXPORTED_FUNCTIONS=_malloc", ], tags = tags + [ diff --git a/sdk_container.sh b/sdk_container.sh index 2b4885f..774fffe 100755 --- a/sdk_container.sh +++ b/sdk_container.sh @@ -81,6 +81,7 @@ rm -rf protobuf-wasm git clone https://github.com/abseil/abseil-cpp cd abseil-cpp git checkout 4447c7562e3bc702ade25105912dce503f0c4010 -b lts20240722 # Abseil LTS release 20240722.0 +# TODO -DSTANDALONE_WASM -sSTANDALONE_WASM ? emcmake cmake -DCMAKE_CXX_STANDARD=17 "." emmake make -j $JOBS cd