Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): add new check ec2_securitygroup_allow_ingress_from_internet_to_tcp_port_solr_7574_8983 #5882

Closed

Conversation

yyyy7246
Copy link

Context

Currently, Prowler rule cover Elasticsearch but lack specific validation for Solr ports (7574, 8983) in EC2 security groups. As Solr is a critical search platform like Elasticsearch, this gap in security validation needs to be addressed to prevent unauthorized access and potential vulnerabilities. This check complements existing security measures by adding dedicated Solr port validation.

Description

Add new check ec2_securitygroup_allow_ingress_from_internet_to_tcp_port_solr_7574_8983 with respective unit tests and metadata.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yyyy7246 yyyy7246 requested review from a team as code owners November 25, 2024 17:59
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 25, 2024
@jfagoagas
Copy link
Member

Hello @yyyy7246 we will review this soon and we'll get back to you once we have an update. Thanks for this contribution and making the cloud a safer place ☁️ 🔒

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (a4c92ea) to head (ad2c55e).
Report is 614 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5882   +/-   ##
=======================================
  Coverage   89.90%   89.90%           
=======================================
  Files        1147     1147           
  Lines       35608    35608           
=======================================
+ Hits        32013    32015    +2     
+ Misses       3595     3593    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puchy22
Copy link
Member

puchy22 commented Nov 26, 2024

Hello @yyyy7246 , for some time we have been trying to avoid this type of checks because they incur in a lot of code repetition. For this reason now there is the configurable check ec2_securitygroup_allow_ingress_from_internet_to_high_risk_tcp_ports that allows you to add the ports that you consider high risk for your organization.
To configure it, you only need to add ports 7574 and 8983 to the list named ec2_high_risk_ports in the configuration file, for more information on this file refer to the documentation https://docs.prowler.com/projects/prowler-open-source/en/latest/tutorials/configuration_file/.

If you have any doubts about more or it does not seem to be an optimal solution do not hesitate to give us your opinion and we will work on it. Thank you very much for using Prowler 💚

@yyyy7246
Copy link
Author

Hello @yyyy7246 , for some time we have been trying to avoid this type of checks because they incur in a lot of code repetition. For this reason now there is the configurable check ec2_securitygroup_allow_ingress_from_internet_to_high_risk_tcp_ports that allows you to add the ports that you consider high risk for your organization. To configure it, you only need to add ports 7574 and 8983 to the list named ec2_high_risk_ports in the configuration file, for more information on this file refer to the documentation https://docs.prowler.com/projects/prowler-open-source/en/latest/tutorials/configuration_file/.

If you have any doubts about more or it does not seem to be an optimal solution do not hesitate to give us your opinion and we will work on it. Thank you very much for using Prowler 💚

Thank you for taking the time to provide your valuable feedback. Next time, I will ensure to explore available features more thoroughly and make a better request. Thank you once again for your support. I will now close this request.

@yyyy7246 yyyy7246 closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants