Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge custom config with prowler's default config #5710

Open
kagahd opened this issue Nov 9, 2024 · 0 comments
Open

merge custom config with prowler's default config #5710

kagahd opened this issue Nov 9, 2024 · 0 comments
Labels
feature-request New feature request for Prowler.

Comments

@kagahd
Copy link
Contributor

kagahd commented Nov 9, 2024

New feature motivation

When using prowler with the option --config-file, the given config file replaces prowler's own default config file. Therefore, users have to merge their config with prowler's config on every new release of prowler which is not only quite tedious but can also be forgotten.
Usually, users put in their custom config only those values that they want to match their specific requirements. These values should just overwrite prowlers default config values.
It is counterintuitive to require the user to provide a complete configuration that is already provided by prowler when they only want to specify a few custom configuration values.

Solution Proposed

I suggest that prowler merges both configs by giving precedence the values of the custom config file passed by --config-file. This behaviour must be documented.

Describe alternatives you've considered

I don't see any alternative. At the very least, the behavior of how a user-defined configuration file is used by prowler, i.e. overwriting or replacing, and also the consequences when upgrading prowler should be clearly documented.

Additional context

No response

@kagahd kagahd added feature-request New feature request for Prowler. status/needs-triage Issue pending triage labels Nov 9, 2024
@pedrooot pedrooot removed the status/needs-triage Issue pending triage label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request for Prowler.
Projects
None yet
Development

No branches or pull requests

2 participants