return in finally can swallow exceptions

[iritkatriel]

Steps to Reproduce

Inspection of source code

Expected behavior

Avoid return in finally.

Actual Result with Screenshots or Logs

There are several places in your code (listed below) where there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if an unhandled exception (including a BaseException such as KeyboardInterrupt) is raised from the try body, or any exception is raised from one of the except: clauses, it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.

prowler/prowler/lib/check/custom_checks_metadata.py

Line 132 in 93d2579

return check_metadata

prowler/prowler/providers/aws/services/iam/iam_service.py

Line 151 in 93d2579

return roles

prowler/prowler/providers/aws/services/iam/iam_service.py

Line 184 in 93d2579

return credential_list

prowler/prowler/providers/aws/services/iam/iam_service.py

Line 203 in 93d2579

return groups

prowler/prowler/providers/aws/services/iam/iam_service.py

Line 215 in 93d2579

return account_summary

prowler/prowler/providers/aws/services/iam/iam_service.py

Line 283 in 93d2579

return stored_password_policy

prowler/prowler/providers/aws/services/iam/iam_service.py

Line 320 in 93d2579

return users

prowler/prowler/providers/aws/services/iam/iam_service.py

Line 338 in 93d2579

return mfa_devices

prowler/prowler/providers/aws/services/iam/iam_service.py

Line 692 in 93d2579

return roles

prowler/prowler/providers/aws/services/iam/iam_service.py

Line 730 in 93d2579

return entities

prowler/prowler/providers/aws/services/iam/iam_service.py

Line 761 in 93d2579

return policies

prowler/prowler/providers/aws/services/iam/iam_service.py

Line 836 in 93d2579

return server_certificates

prowler/prowler/providers/aws/services/iam/iam_user_two_active_access_key/iam_user_two_active_access_key.py

Line 38 in 93d2579

return findings

How did you install Prowler?

NA

Environment Resource

NA

OS used

NA

Prowler version

master branch

Pip version

NA

Context

No response

[MrCloudSec]

Hi @iritkatriel, I will review this logic internally with the team and I will come back with a solution. Thanks for letting us know!