From e7705752d67e6893e1e818db25ad5fae1d31099e Mon Sep 17 00:00:00 2001
From: Pepe Fagoaga <pepe@prowler.com>
Date: Thu, 23 Jan 2025 13:07:59 +0100
Subject: [PATCH] chore(scan): Remove ._findings

---
 prowler/lib/scan/scan.py    | 8 --------
 tests/lib/scan/scan_test.py | 1 -
 2 files changed, 9 deletions(-)

diff --git a/prowler/lib/scan/scan.py b/prowler/lib/scan/scan.py
index 213161b64b5..8c40db55a86 100644
--- a/prowler/lib/scan/scan.py
+++ b/prowler/lib/scan/scan.py
@@ -36,7 +36,6 @@ class Scan:
     _service_checks_to_execute: dict[str, set[str]]
     _service_checks_completed: dict[str, set[str]]
     _progress: float = 0.0
-    _findings: list = []
     _duration: int = 0
     _status: list[str] = None
 
@@ -216,10 +215,6 @@ def progress(self) -> float:
     def duration(self) -> int:
         return self._duration
 
-    @property
-    def findings(self) -> list:
-        return self._findings
-
     def scan(
         self,
         custom_checks_metadata: dict = {},
@@ -282,9 +277,6 @@ def scan(
                             if finding.status not in self._status:
                                 check_findings.remove(finding)
 
-                    # Store findings
-                    self._findings.extend(check_findings)
-
                     # Remove the executed check
                     self._service_checks_to_execute[service].remove(check_name)
                     if len(self._service_checks_to_execute[service]) == 0:
diff --git a/tests/lib/scan/scan_test.py b/tests/lib/scan/scan_test.py
index 715c4dbc776..d51d26c3a3f 100644
--- a/tests/lib/scan/scan_test.py
+++ b/tests/lib/scan/scan_test.py
@@ -333,7 +333,6 @@ def test_scan(
         assert scan.service_checks_completed == {
             "accessanalyzer": {"accessanalyzer_enabled"},
         }
-        assert scan.findings == mock_execute.side_effect()
         mock_logger.error.assert_not_called()
 
     def test_init_invalid_severity(