Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for clojurescript #14

Open
ghaskins opened this issue Nov 8, 2019 · 1 comment
Open

Add support for clojurescript #14

ghaskins opened this issue Nov 8, 2019 · 1 comment
Assignees
@ghaskins

Comments

@ghaskins
Copy link
Member

ghaskins commented Nov 8, 2019

No description provided.

@ghaskins ghaskins self-assigned this Nov 8, 2019
ghaskins added a commit to ghaskins/protojure-lib that referenced this issue Dec 29, 2019
@ghaskins
[protojure#14] Remove length calculation
fdde7a9 
Clojurescript doesn't have a method to compute the size of protobuf messages, and
we can get away without having one by using auto-expanding ByteArrayOutputStream
types.  We therefore remove support for all the size-XX serdes and (pb/length)
functions.  This is part of the breaking changes to support both Clojure
and Clojurescript

Partially addresses protojure#14

Signed-off-by: Greg Haskins <[email protected]>
ghaskins added a commit to ghaskins/protojure-lib that referenced this issue Dec 29, 2019
@ghaskins
[protojure#14] Split up code in preparation for clojurescript support
fe51874 
We need to split out common code from clojure/jvm specific code so that
we may pave the way for clojurescript support in a future patch.

Partially addresses protojure#14

Signed-off-by: Greg Haskins <[email protected]>
@ghaskins ghaskins mentioned this issue Dec 29, 2019
Merged
ghaskins added a commit that referenced this issue Dec 29, 2019
@ghaskins
[#14] Remove length calculation
b39bf55 
Clojurescript doesn't have a method to compute the size of protobuf messages, and
we can get away without having one by using auto-expanding ByteArrayOutputStream
types.  We therefore remove support for all the size-XX serdes and (pb/length)
functions.  This is part of the breaking changes to support both Clojure
and Clojurescript

Partially addresses #14

Signed-off-by: Greg Haskins <[email protected]>
ghaskins added a commit that referenced this issue Dec 29, 2019
@ghaskins
[#14] Split up code in preparation for clojurescript support
4b9cd1c 
We need to split out common code from clojure/jvm specific code so that
we may pave the way for clojurescript support in a future patch.

Partially addresses #14

Signed-off-by: Greg Haskins <[email protected]>
ghaskins added a commit that referenced this issue Jan 1, 2020
@ghaskins
Release v1.1.0
9a43f31 
Changes since v1.0.2
----
6616726 Use a general link to the cljdoc
4b9cd1c [#14] Split up code in preparation for clojurescript support
b39bf55 [#14] Remove length calculation
df9ef13 [#15] Convert serdes from eval+intern to pure macros

Signed-off-by: Greg Haskins <[email protected]>
@st-cheewah
Copy link

any chance this feature will be available soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghaskins ghaskins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ghaskins @st-cheewah