Proper fix utf8 command line arguments (#14253) #15519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
#14197 Tried to fix utf-8 issue, but it didnt handle multibyte chars. Only way I found that works constantly is using `CommandLineToArgvW`. To not ripple out `wchar_t`, I convert to and from where needed Closes #14253 COPYBARA_INTEGRATE_REVIEW=#14253 from hknielsen:proper-fix-none-ascii-issue cad753e PiperOrigin-RevId: 599990369
copybara-service
bot
force-pushed
the
test_599826579
branch
from
e67b009
to
1eff9d7
Compare
copybara-service
bot
closed this pull request by merging all changes
into
main
in
1eff9d7
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
This relates to: Issues: - #17036 - grpc/grpc#36518 PRs: - #15519 The fix in #15519 has one line missing that breaks `Grpc.Tools` and doesn't actually fix the problem it proports to fix. This PR fixes this. This fix needs to also be applied to the version of protobuf that is used by gRPC. There are various scenarios that need to be tested on Windows: **A. Non-ascii command line arguments, e.g.** ``` protoc.exe --csharp_out=out --proto_path=E:\work\grpc\protoctest\test-Dré E:\work\grpc\protoctest\test-Dré\helloworld.proto ``` Failed output: ``` E:\work\grpc\protoctest\test-DrΘ: warning: directory does not exist. Could not make proto path relative: E:\work\grpc\protoctest\test-DrΘ\helloworld.proto: No such file or directory ``` Success output: - no errors printed - generated `.cs` file in the `out` directory **B. Non-ascii arguments in a file containing the protoc arguments (no path to file) e.g.:** ``` protoc.exe @test.rsp ``` where `test.rsp` contains: ``` --plugin=protoc-gen-grpc=E:\work\grpc\protoctest\tools\grpc_csharp_plugin.exe --csharp_out=E:\work\grpc\protoctest\test-Dré\out --grpc_out=E:\work\grpc\protoctest\test-Dré\out --proto_path=E:\work\grpc\protoctest\test-Dré helloworld.proto ``` Success output for both old and fixed code: - no errors printed - generated `.cs` file in the `out` directory **C. Non-ascii arguments in a file containing the protoc arguments (with non-ascii path to file).** (This is what `Grpc.Tools` uses.) e.g. ``` protoc.exe @e:\work\grpc\protoctest\test-Dré\test.rsp ``` Failed output: ``` Failed to open argument file: E:\work\grpc\protoctest\test-DrΘ\test.rsp ``` Success output: - no errors printed - generated `.cs` file in the `out` directory Closes #17854 COPYBARA_INTEGRATE_REVIEW=#17854 from tonydnewell:windows-utf8-command-fix de9ec54 PiperOrigin-RevId: 669083804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper fix utf8 command line arguments (#14253)
#14197
Tried to fix utf-8 issue, but it didnt handle multibyte chars.
Only way I found that works constantly is using
CommandLineToArgvW.To not ripple out
wchar_t, I convert to and from where neededCloses #14253
COPYBARA_INTEGRATE_REVIEW=#14253 from hknielsen:proper-fix-none-ascii-issue cad753e
FUTURE_COPYBARA_INTEGRATE_REVIEW=#14253 from hknielsen:proper-fix-none-ascii-issue cad753e