-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
//:python_srcs doesn't play nice with other Google libraries #4658
Comments
Is there any expectation to when this will get released? (I don't want to use the master branch in my project, if possible). |
@mishas 3.6.x branch will not have this fix unless someone cherry-picks the change to that branch. @anandolee Jie, can you evaluate whether we should cherry-pick the fix for this issue and include it in another 3.6.x patch release? |
If we are going to have another 3.6.x release, I can do the cherrypick. But not worth to do another 3.6.X release only for this change. I will take care of it to make sure it is in next release anyway. |
Do I understand this correct, that this will install an See http://python-notes.curiousefficiency.org/en/latest/python_concepts/import_traps.html#the-init-py-trap for details. |
We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment. This issue is labeled |
We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it. This issue was closed and archived because there has been no new activity in the 14 days since the |
//:python_srcs
doesn't includepython/google/__init__.py
in itssrcs
glob. Without it, protobuf exclusively defines a top-levelgoogle
namespace which breaks other packages like google-auth that expect to share thegoogle
namespace.The text was updated successfully, but these errors were encountered: