Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//:python_srcs doesn't play nice with other Google libraries #4658

Closed
calder opened this issue May 21, 2018 · 6 comments · Fixed by #4659
Closed

//:python_srcs doesn't play nice with other Google libraries #4658

calder opened this issue May 21, 2018 · 6 comments · Fixed by #4659
Assignees
Labels
bug inactive Denotes the issue/PR has not seen activity in the last 90 days. python

Comments

@calder
Copy link
Contributor

calder commented May 21, 2018

//:python_srcs doesn't include python/google/__init__.py in its srcs glob. Without it, protobuf exclusively defines a top-level google namespace which breaks other packages like google-auth that expect to share the google namespace.

@mishas
Copy link
Contributor

mishas commented Aug 6, 2018

Is there any expectation to when this will get released? (I don't want to use the master branch in my project, if possible).
This is already merged for more than 2 months...
There were 2 major releases since this got merged (3.6.0 and 3.6.1), and 3 additional minor once (3.6.0rc1,3.6.0rc2 and 3.6.0.1), and none of them had this fix in them.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Aug 6, 2018

@mishas 3.6.x branch will not have this fix unless someone cherry-picks the change to that branch.

@anandolee Jie, can you evaluate whether we should cherry-pick the fix for this issue and include it in another 3.6.x patch release?

@anandolee
Copy link
Contributor

anandolee commented Sep 10, 2018

If we are going to have another 3.6.x release, I can do the cherrypick. But not worth to do another 3.6.X release only for this change. I will take care of it to make sure it is in next release anyway.
@xfxyjwf I guess there's no plan for another 3.6.x release so far?

@Flamefire
Copy link

Do I understand this correct, that this will install an __init__.py in the google folder? If so, then please don't! It will break using different folders with google.* packages and is completely unnecessary for Python >= 3.3 (2.7 will drop out of support by the end of the year, and 3.3 and below already are)

See http://python-notes.curiousefficiency.org/en/latest/python_concepts/import_traps.html#the-init-py-trap for details.

Copy link

github-actions bot commented Jun 2, 2024

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Jun 2, 2024
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it.

This issue was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug inactive Denotes the issue/PR has not seen activity in the last 90 days. python
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants