-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protobuf-java-util gson dep from v2.7 to v2.8.1 #3531
Comments
Will the 2.8.1 be binary compatible with 2.7? I'm just cautious about whether this will break other users of protobuf. |
I'm not sure. Is there a way to tell? |
Are you directly depending on a newer version of gson? If so, can't gradle pick the newer version automatically? |
I have to do this: androidTestCompile('io.grpc:grpc-protobuf:1.5.0') {
exclude group: 'com.google.code.gson', module: 'gson'
} It works fine so there's no problem. I was just wondering when these dependencies get updated in It's possible that upgrading would break people. |
What happens if you don't use "exclude ..."? |
This:
|
This seems an issue in your configuration. Have you tried the suggestions in the linked android studio doc? Specifically it suggests:
|
The app is setting the required version of gson via an indirect dependency. If I explicitly depend on a version of gson, that will work for now but may break in the future. Excluding means I'm using the same version of gson as the app, regardless of which version that happens to be. I don't have to update it in the future. Ideally the dependencies would update over time. If gson ever broke their API then this exclude strategy would stop working. I'm not sure what kind of guarantees they provide around API stability. To clarify there are a few options which work:
I'm mostly interested in why grpc-protobuf depends on gson from 2016. It sounds like there are compatibility concerns around upgrading. |
protobuf-java-util isn't using the latest gson. I had to add a gradle exclude rule. It'd be nice to update to the latest stable version.
The text was updated successfully, but these errors were encountered: