-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a module-info.java
#16133
Comments
We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment. This issue is labeled |
Bump! |
I don't understand why this can't be done. It seems like jlink is a great way to create a stand alone app, but we cannot use protobuf with it. |
We are willing to help on this effort, we would like very much to have JPMS support for Google Protobuf library |
We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment. This issue is labeled |
We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it. This issue was closed and archived because there has been no new activity in the 14 days since the |
What language does this apply to?
If it's a proto syntax change, is it for proto2 or proto3?
N/A
If it's about generated code change, what programming language?
Java
Describe the problem you are trying to solve.
I want to use Protobuf Java with
jlink
. Unfortunately,jlink
rejects JARs with anAutomatic-Module-Name
set; it is required to define amodule-info.java
.Describe the solution you'd like
I would like Protobuf Java to ship a
module-info.java
, in an MRJAR, to preserve existing JDK support. I am not proposing a change to the JVM bytecode minimum support level.Describe alternatives you've considered
I have considered solutions like Moditect, but they complicate my build greatly because dependencies must be transformed before being consumed by the Java Compiler.
Additional context
Guava is considering a PR for this. Recently, Error Prone and other core libs have released new versions with a
module-info.java
definition. Thus, Protobuf's transitive dependencies may be ready for a fully modular Java build.The text was updated successfully, but these errors were encountered: