Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

descriptor.proto not found #17

Open
byrnedo opened this issue Mar 1, 2017 · 2 comments
Open

descriptor.proto not found #17

byrnedo opened this issue Mar 1, 2017 · 2 comments

Comments

@byrnedo
Copy link

byrnedo commented Mar 1, 2017

I updated to the latest version and I got the following when running

google/protobuf/descriptor.proto: File not found.
github.com/gogo/protobuf/gogoproto/gogo.proto: Import "google/protobuf/descriptor.proto" was not found or had errors.

I noticed the that protobuf command was (via '--include-descriptors') adding the following:

'--proto_path=/my/project/vendor/protobuf-php/google-protobuf-proto/src'

I looked in that folder and the descriptor file is in there:

google  descriptor.proto  php.proto  plugin.proto

But I guess it's then going into google/protobuf in that dir, which doesn't have the descriptor.proto file

Has there been some change that would cause this?

@FabioBatSilva
Copy link
Member

if you want to use the protos defined in vendor/protobuf-php/google-protobuf-proto
I believe it should be import descriptor.proto instead of import google/protobuf/descriptor.proto

IRC by using google/protobuf/descriptor.proto protoc will try to look up the descriptor.proto provided by https://github.com/google/protobuf

@byrnedo
Copy link
Author

byrnedo commented Mar 8, 2017

OK, but I was pretty sure the standard is the fully qualified name, like according to https://developers.google.com/protocol-buffers/docs/proto#customoptions.

So shouldn't the --include-descriptors flag not honor that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants