fix!: r144 geometry rename #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thank you for this. I had a very similar changeset in my local but hadn't pushed it yet. I'm in favor of the I'll try and get this tested/merged/released in the next day or two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192. Since r125 (mrdoob/three.js#21031),
THREE.PlaneBufferGeometryetc. were aliased toTHREE.PlaneGeometryand vice versa with the removal ofTHREE.Geometry. In r144 (mrdoob/three.js#24352),THREE.PlaneBufferGeometryis deprecated and slated for removal in r154 in favor ofTHREE.PlaneGeometry(they were effectively renamed).This is a breaking change and will bump the minimum supported version of three to r125 in all packages that use built-in geometry.