Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari WebGL Shader error "'round' : no matching overloaded function found" #108

Closed
MaxTwentythree opened this issue Feb 18, 2021 · 3 comments

Comments

@MaxTwentythree
Copy link

MaxTwentythree commented Feb 18, 2021

Hi,
in Safari troika text isn't rendered anymore .. I receive the following WebGL Shader error:

"THREE.WebGLShader: gl.getShaderInfoLog() fragment
ERROR: 0:385: 'round' : no matching overloaded function found

It's this line in the Shader:

385: float ch = round(vTroikaTextureChannel);

Unfortunatelly I'm not sure with which troika-three-text version this started ..
I'm currently on 0.39.1
My three version is 0.125.2

Is this just me, or does someone else also have this problem?

@MaxTwentythree MaxTwentythree changed the title Safari WeebGL Shader error "'round' : no matching overloaded function found" Safari WebGL Shader error "'round' : no matching overloaded function found" Feb 18, 2021
@lojjic
Copy link
Collaborator

lojjic commented Feb 18, 2021

Oof, guess I need to be better about testing Safari in my release process. I'd been getting lazy.

I'll put out a fix shortly.

@lojjic lojjic closed this as completed in cdbc7dc Feb 18, 2021
@lojjic
Copy link
Collaborator

lojjic commented Feb 18, 2021

I've released 0.39.2 with the fix, let me know if you still see issues.

@MaxTwentythree
Copy link
Author

Yay, this was fast!
Thank you, it's working now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants