Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade depencencies for python 3.12 / pylint 3.0+ #678

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

Pierre-Sassoulas
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas commented Oct 9, 2024

This removes pylint-plugin-utils, upgrade requirements-detector to the only version that can work, and prepare for the next release of pylint-django (that is necessary for python 3.12.)

Fix #676

Refs pylint-dev/pylint-django#444 https://github.com/pylint-dev/pylint-django/releases/tag/v2.6.0

@Pierre-Sassoulas Pierre-Sassoulas added this to the 1.12.1 milestone Oct 9, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it'd be very useful, Prospector functionality permitting, to relax the upper pin on flake8, they are already at 7.1-7.2 👍🍺

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 2c01a78

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent many thanks @Pierre-Sassoulas 🍺

Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)

@Pierre-Sassoulas Pierre-Sassoulas merged commit 34fd000 into master Oct 10, 2024
6 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the clean-up-dependencies branch October 10, 2024 08:25
@sbrunner
Copy link
Member

@Pierre-Sassoulas shouldn't we create now the release 1.12.1?

@valeriupredoi
Copy link
Collaborator

Yes, if the PyPI package is released, then I'll build and release the conda package today 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade requirements-detector / remove pylint-plugin-utils as a direct dependency
3 participants