Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering channel name with @ should change button title #136

Closed
nesium opened this issue Aug 20, 2024 · 1 comment
Closed

Entering channel name with @ should change button title #136

nesium opened this issue Aug 20, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@nesium
Copy link
Contributor

nesium commented Aug 20, 2024

The "Create Channel" button title should match the application logic…

// Join or create room?
if (jidString.includes("@") === true) {
  // Join room identified by parsed JID
  roomJID = await Broker.$room.join(new JID(jidString));
  // …
}
// …

and change to "Join Channel" when the channel's name contains an @

@nesium
Copy link
Contributor Author

nesium commented Aug 20, 2024

Actually I think that "Create" and "Join" should be clearly separated.

Say I have a private room "abc" on the same server where my account is and want to join it.

I click "Add a channel". Should I enter the full address here even though it's the same server? That would differ from the behavior of joining a public room.

So I enter "abc" and click "Create Channel". The web app now tries to find the room "abc" by calling findPublicChannelByName which fails, since the room is private. It then proceeds to call createPublicChannel which creates a new channel with that name but a different identifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants