Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back "miscellaneous" matplotlib colormaps #123

Closed
mickaellalande opened this issue Feb 14, 2020 · 3 comments
Closed

Add back "miscellaneous" matplotlib colormaps #123

mickaellalande opened this issue Feb 14, 2020 · 3 comments
Labels

Comments

@mickaellalande
Copy link
Contributor

It would be nice to have by default all the colormaps from Matplotlib (https://matplotlib.org/examples/color/colormaps_reference.html) in particular the jet one for example that I was used to pick, because more visible than the Spectral one in Proplot. But the terrain one is also useful, etc. I don't know if there is particular attention for colorblind people and if it goes in that way or not (I don't have any knowledge on that)?

@mickaellalande mickaellalande changed the title Matplotlib colorbars Matplotlib colormaps Feb 14, 2020
@lukelbd
Copy link
Collaborator

lukelbd commented Feb 15, 2020

So the reason we removed jet is to strong-arm users into using "perceptually uniform" colormaps -- check out this workshop @bradyrx and I hosted (see the slides in the "powerpoint" folder and the notebooks in the "notebooks" folder).

But I think you're right, it is probably preferable to keep these colormaps "resistered" but just hide them from the colormap table (I do the same thing by hiding matplotlib's CSS colors to push users toward xkcd colors). Also topographic colormaps kind of defy the typical colormap categorization into sequantial/diverging/qualitative, so even though they are generally not "perceptually uniform" there's no reason they should be deleted.

I will add back the colormaps then maybe add an ignore keyword arg to show_cmaps that can be used to ignore certain categories. By default, it will ignore the maps in the "Miscellaneous colormaps" category.

@lukelbd lukelbd changed the title Matplotlib colormaps Add back "miscellaneous" matplotlib colormaps Feb 15, 2020
@mickaellalande
Copy link
Contributor Author

Ok, great thanks for the explanations, I was a bit expecting this kind of answer, but it was still unclear for me. Because many "old" supervisors will ask for this jet colormap to "see something", however next time I will show them your presentation 🤣.

@lukelbd
Copy link
Collaborator

lukelbd commented May 9, 2020

This was fixed by ce4ef6a. "Bad" colormaps are no longer deleted

@lukelbd lukelbd closed this as completed May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants